Credential Representations #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lifts the 1-1 relation between credential type and credential representation (SD-JWT, plain JWT, ISO MDOC)
vclib-openid/src/commonMain/kotlin/at/asitplus/wallet/lib/oidc/OidcSiopVerifier.kt
Show resolved
Hide resolved
vclib/src/commonMain/kotlin/at/asitplus/wallet/lib/data/AriesGoalCodeParser.kt
Outdated
Show resolved
Hide resolved
vclib/src/commonMain/kotlin/at/asitplus/wallet/lib/iso/MobileDrivingLicenceJwsNamespace.kt
Show resolved
Hide resolved
JesusMcCloud
approved these changes
Oct 30, 2023
nodh
force-pushed
the
feature/iso-credentials
branch
from
36fd4c4 to
061b926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits lifts the 1-1 relation between credential and its format. Now, any credential can be represented in any format (that is SD-JWT, Plain JWT, ISO MDOC), when supported by the implementation of the
IssuerCredentialDataProvider.As a consequence, the Wallet may request the same credential type from the backend in all three representations and store them. When a Verifier later on requests the credential type in a specific representation, the Wallet can create a presentation in the requested format.
In other news, the implementation of a custom
CredentialSchemegot a bit easier, as thegetClaims()method fromCredenitalSubjecthas been dropped (introduced in 3.1.0).Please note that this applies to the OpenId protocol implementations only, as upgrading the ARIES protocols seems not worth the effort.